Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove signature/proof_of_possession from message_hash calculation. - (Spec PR #725) #468

Closed
schroedingerscode opened this issue Mar 15, 2019 · 0 comments
Closed

Remove signature/proof_of_possession from message_hash calculation. - (Spec PR #725) #468

schroedingerscode opened this issue Mar 15, 2019 · 0 comments
Assignees
@akhila-raju
Labels
blocked by another PR/issue 💔 This issue or pull request is blocked by another enhancement 🕵️‍♀️ New feature or request

Comments

@schroedingerscode
Copy link
Contributor

schroedingerscode commented Mar 15, 2019 •
edited
Loading

Description

As an implementor, I want to calculate the message_hash by calling signed_root without the signature parameter so that the signature parameter is not truncated away when the message hash is calculated.

Acceptance Criteria

  • Call to signed_root when calculating the message hash in BlockProcessorUtil#processDeposits does not specify a truncation field.
  • Call to signed_root when calculating the message hash in BlockProcessorUtil#verify_signature does not specify a truncation field.
  • Call to signed_root when calculating the message hash in BlockProcessorUtil#proposer_slashing does not specify a truncation field.
  • Call to signed_root when calculating the message hash in BlockProcessorUtil#processExits does not specify a truncation field.
  • Call to signed_root when calculating the message hash in BlockProcessorUtil#processTransfers does not specify a truncation field.

Additional Information

See ethereum/consensus-specs#725
Coupled to and depends on v0.4.0 completion.
@schroedingerscode schroedingerscode added enhancement 🕵️‍♀️ New feature or request blocked by another PR/issue 💔 This issue or pull request is blocked by another labels Mar 15, 2019
@schroedingerscode schroedingerscode added this to the Beacon Chain v0.5.0 Spec milestone Mar 15, 2019
@akhila-raju akhila-raju changed the title Remove signature/proof_of_possession from message_hash calcuation. - (Spec PR #725) Remove signature/proof_of_possession from message_hash calculation. - (Spec PR #725) Apr 11, 2019
@jrhea jrhea mentioned this issue May 8, 2019
Closed
26 tasks
@jrhea jrhea closed this as completed Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akhila-raju akhila-raju

Labels
blocked by another PR/issue 💔 This issue or pull request is blocked by another enhancement 🕵️‍♀️ New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@akhila-raju @jrhea @schroedingerscode