Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the "ready to exit" condition in update_validator_registry (Spec PR #705) #475

Closed
akhila-raju opened this issue Mar 15, 2019 · 0 comments
Closed

Fix the "ready to exit" condition in update_validator_registry (Spec PR #705) #475

akhila-raju opened this issue Mar 15, 2019 · 0 comments
Labels
bug 🐞 Something isn't working good first issue 🙋 This is a good first issue for a new contributor to work on

Comments

@akhila-raju
Copy link
Contributor

akhila-raju commented Mar 15, 2019 •
edited
Loading

Description

  1. The ready to exit condition in update_validator_registry should use validator.exit_epoch to determine. Change to condition from validator.activation_epoch == FAR_FUTURE_EPOCH and validator.initiated_exit to validator.exit_epoch == FAR_FUTURE_EPOCH and validator.initiated_exit
  2. Refactor exit_validator.

See Spec PR #705.
@akhila-raju akhila-raju added this to the Beacon Chain v0.5.0 Spec milestone Mar 15, 2019
@akhila-raju akhila-raju added the bug 🐞 Something isn't working label Mar 15, 2019
@akhila-raju akhila-raju changed the title Fix the "ready to exit" condition in update_validator_registry Fix the "ready to exit" condition in update_validator_registry (Spec PR #705) Mar 15, 2019
@akhila-raju akhila-raju self-assigned this Mar 15, 2019
@akhila-raju akhila-raju removed their assignment Mar 28, 2019
@akhila-raju akhila-raju added the good first issue 🙋 This is a good first issue for a new contributor to work on label Mar 28, 2019
@jrhea jrhea closed this as completed May 8, 2019
@jrhea jrhea mentioned this issue May 8, 2019
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐞 Something isn't working good first issue 🙋 This is a good first issue for a new contributor to work on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akhila-raju @jrhea