Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty BlobsSidecar Handling #6767

Closed
tbenr opened this issue Feb 2, 2023 · 1 comment
Closed

Empty BlobsSidecar Handling #6767

tbenr opened this issue Feb 2, 2023 · 1 comment
Labels
Epic Deneb Issues required to implement Deneb upgrade

Comments

@tbenr
Copy link
Contributor

tbenr commented Feb 2, 2023 •
edited by StefanBratanov
Loading

These PRs given:

ethereum/consensus-specs#3174
ethereum/consensus-specs#3242

Given that we respond "Resource Unavailable" when we fail the test oncheckBlobsSidecarsAreAvailable.

Problem 1:
If we have an entyre epoch of empty blobs sidecars, we will not store anything on DB. If this epoch is the oldest epoch in DA window, we return "Resource Unavailable" even if it it's the case.

Options are:

  • we should start writing empty blobs sidecars on DB when we do not receive them when syncing.
  • Move away from tracking DA window from earliest blobsSidecar slot in DB and explicitly tracking it via a DB variable.

Problem 2:
Captured by #6788
@tbenr tbenr added the Epic Deneb Issues required to implement Deneb upgrade label Feb 2, 2023
@StefanBratanov StefanBratanov mentioned this issue Feb 8, 2023
Closed
@zilm13
Copy link
Contributor

zilm13 commented Jul 1, 2023

Fixed with #7295 and #7128

@zilm13 zilm13 closed this as completed Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Epic Deneb Issues required to implement Deneb upgrade
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zilm13 @tbenr