Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra logging for errors #805

Closed
prd-fox opened this issue Jun 25, 2019 · 2 comments · Fixed by #810
Closed

Extra logging for errors #805

prd-fox opened this issue Jun 25, 2019 · 2 comments · Fixed by #810
Labels
0.10.0 feature User features

Comments

@prd-fox
Copy link
Contributor

prd-fox commented Jun 25, 2019

The DefaultExceptionMapper is providing the stack trace at the debug level.
This means that trying to diagnose issues can be troublesome without knowing where they occurred in the application.

Additionally, the PartyInfoPoller doesn't tell us the URL when a general exception happens. This should be changed to be the same as the ConnectException clause.

We can either:

  • increase the level they are logged at
  • make it easier to run with the debug logging enabled
@prd-fox
Copy link
Contributor Author

prd-fox commented Jun 25, 2019

There can also be too much logging when peers are unable to connect. Although it is useful to report this, it can quickly overwhelm the logs with duplicate info. We should find a way to report the error fully once within a time period, and then a limited amount of info for the same message. See #804 and https://go-quorum.slack.com/archives/C825QTQ1Z/p1561447073127100 for more info.

@chris-j-h
Copy link
Collaborator

Another way to reduce the noise when logging errors is to make the distinction between critical and non-critical errors. Being unable to connect to a peer is an error but does not necessarily require immediate concern/action.

@prd-fox prd-fox added the feature User features label Jun 27, 2019
@prd-fox prd-fox added the 0.10.0 label Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.10.0 feature User features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants