Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If an error is encountered, update Postgres DB task row (status and errormessage) #50

Closed
rudokemper opened this issue May 2, 2024 · 3 comments · Fixed by #51
Closed
Assignees
Labels

Comments

@rudokemper
Copy link
Member

n/t

@rudokemper rudokemper added the MVP label May 2, 2024
@rudokemper rudokemper self-assigned this May 2, 2024
@IamJeffG
Copy link
Contributor

IamJeffG commented May 2, 2024

This comment is just FYI and I don't think you should go divert from the existing plan. But I read https://taylor.town/pg-task and really liked it -- it roughly describes a way that we could drop Azure Storage Queue entirely. And in fact I've followed his pattern in something on the acoustic side, works pretty well!

@rudokemper
Copy link
Member Author

Just skimmed it and it absolutely resonates with me - and I think I was hoping for something like this in the initial iteration of the design doc.

Adopting this approach will make it much easier to make the map-packer + mapgl-tile-renderer toolchain run anywhere.

But yes, this far into work towards an MVP, we probably shouldn't divert from the plan (but judging by the implementation code, I also don't think it would be a ton of work to drop ASQ for this approach, especially if you have experience on the acoustics side!)

@IamJeffG
Copy link
Contributor

IamJeffG commented May 2, 2024

One reason I suggest holding off is it will require refactoring / splitting your SQL tables. This wasn't obvious to me at first but I quickly found out when implementing. Basically the task queue table needs to be only a task queue, and cannot power anything else, e.g. the list of maps in the webapp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants