added new bins to 'MasterCard' #44
Conversation
Included new beginnings for Mastercard will be available in October: 2221 2222 223 2[3-6] 27[01] 2720
|
You changed source files, but no tests were changed. It might be OK if this is a refactory and no behavior has changed, |
|
@rnldfll, thanks for your PR! By analyzing the blame information on this pull request, we identified @fernahh to be a potential reviewer |
|
@rnldfll do you have reference about this information? |
| @@ -20,6 +20,7 @@ const CREDIT_CARD_LIST = [ | |||
| }, { | |||
| name: 'Mastercard', | |||
| regexpFull: '^5[1-5][0-9]{14}$' | |||
| //regexpFull: '^((5[1-5][0-9]{14})|(2221[0-9]{12})|(222[2-9][0-9]{12})|(22[3-9][0-9]{13})|(2[3-6][0-9]{14})|(27[01][0-9]{13})|(2720[0-9]{12}))$' //After October | |||
There was a problem hiding this comment.
In the PR description is mentioned 2222, but in the regex it turned into (222[2-9][0-9]{12}), which is not the same.
In the PR description is mentioned 223, but in the regex it turned into (22[3-9][0-9]{13}), which is not the same.
Also, the inner parenthesis are not necessary:
From: ^((5[1-5][0-9]{14})|(2221[0-9]{12})|(222[2-9][0-9]{12})|(22[3-9][0-9]{13})|(2[3-6][0-9]{14})|(27[01][0-9]{13})|(2720[0-9]{12}))$
To : ^(5[1-5][0-9]{14}|2221[0-9]{12}|222[2-9][0-9]{12}|22[3-9][0-9]{13}|2[3-6][0-9]{14}|27[01][0-9]{13}|2720[0-9]{12})$
|
@fernahh Yes, I received an email from a card service that uses the Mastercard and i'm using an Apache 's validator that already contains this information . Link below: @aureliojargas Is wrong in the PR description, the regex is ok i think. Sorry for the mistake. Please check the link above and confirm that. About the parenteses you're right, Thanks. |
|
@rnldfll I'm awaiting your improvements identified by @aureliojargas, ok? |
|
@fernahh Done |
|
@rnldfll You have removed the outer parenthesis, not the inner parenthesis. Please see my previous comment. |
|
@rnldfll ping |
|
👍 |
|
Thanks for PR, @rnldfll! Next week we will release a new version. |
New initial digits will be available in October for Mastercard :
222100 - 222199
222200 - 222999
223000 - 229999
230000 - 269999
270000 - 271999
272000 - 272099