Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expiration check fails #34

Closed
jdforsythe opened this issue Mar 18, 2016 · 2 comments
Closed

Expiration check fails #34

jdforsythe opened this issue Mar 18, 2016 · 2 comments
Labels

Comments

@jdforsythe
Copy link

There are two issues with expiration date checking.

First is the line:

if (yearLength < 2 && yearLength > 4) return false;

yearLength can't be both less than 2 and greater than 4.

Second is the line:

return !(y < 1000 || y >= 3000);

This fails on two-digit expiration years, which are less than 1000.

@jdforsythe
Copy link
Author

It appears that the first line is not present in the current repo when I forked it, but is in the bower package.

@fernahh
Copy link
Contributor

fernahh commented Mar 18, 2016

This problem got fixed on v2.0.3, but I not created a Github release. I did it now. It will soon be in the Bower.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants