Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First version of the Readme #1

Merged
merged 19 commits into from Apr 9, 2021
Merged

First version of the Readme #1

merged 19 commits into from Apr 9, 2021

Conversation

lucaSchilling
Copy link
Member

@lucaSchilling lucaSchilling commented Feb 26, 2021

I created a first version of the README.
Since your english is better then mine it would be great if you could read through it.
Maybe I will add more sections later depending on what comes into my mind.

Copy link
Member

@ChristianCoenen ChristianCoenen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like it, it's very detailed.

I added multiple comments with suggestions (mostly language-related)

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@lucaSchilling
Copy link
Member Author

lucaSchilling commented Mar 4, 2021

I changed everything as suggested by you. Only some things I changed even more check the comments about these if those things are fine we can probably merge this PR.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@lucaSchilling lucaSchilling changed the base branch from master to main April 8, 2021 10:13
@lucaSchilling lucaSchilling dismissed MorMundHS-MA’s stale review April 9, 2021 12:21

Because he is sick and not in the weekly meeting

@lucaSchilling lucaSchilling merged commit 3d6cbf3 into main Apr 9, 2021
@lucaSchilling lucaSchilling deleted the README branch April 9, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants