This repository has been archived by the owner on Mar 18, 2022. It is now read-only.
add RequireClaim middleware for usage in consumer projects. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 39
💛 - Coveralls |
LucasRoesler
suggested changes
Sep 4, 2018
middleware.go
Outdated
|
|
||
| func RequireClaim(handler http.Handler, idpKey interface{}, header, claimKey, expectedClaimValue string) http.Handler { | ||
| return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| _, claims, err := GetClaimsFromRequestWithValidation(r, idpKey) |
There was a problem hiding this comment.
Seems like this shouldn't validate the claims here, validation should happen in a separate middleware
There was a problem hiding this comment.
A jwt is a signed json blob, so why shouldn't we validate the signature and expiry in the auth middleware, especially when it's just a 10 line middleware?
There was a problem hiding this comment.
I refactored that so that we now extract and validate the token in a seperate middleware and store the claims in the requests context. With that in place it will be easy to continue working on the claims in http handlers further down the handler tree.
@LucasRoesler Ping :) This can be reviewed again.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.