Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix isnan with postgres #1123

Merged
merged 1 commit into from
Jun 11, 2015
Merged

Conversation

llllllllll
Copy link
Member

sqlite does not have a NaN value so I don't test against it.

@cpcloud cpcloud added this to the 0.8.1 milestone Jun 11, 2015
@cpcloud
Copy link
Member

cpcloud commented Jun 11, 2015

wacky.

from the postgresql docs: http://www.postgresql.org/docs/current/static/datatype-numeric.html

Note: In most implementations of the "not-a-number" concept, NaN is not considered equal to any other numeric value (including NaN). In order to allow numeric values to be sorted and used in tree-based indexes, PostgreSQL treats NaN values as equal, and greater than all non-NaN values.

@cpcloud
Copy link
Member

cpcloud commented Jun 11, 2015

So apparently there is something bigger than infinity:

pcloud=# select float8 'NaN' > float8 'Infinity';
 ?column?
----------
 t
(1 row)

cpcloud added a commit that referenced this pull request Jun 11, 2015
@cpcloud cpcloud merged commit 29c11ae into blaze:master Jun 11, 2015
@cpcloud
Copy link
Member

cpcloud commented Jun 11, 2015

@llllllllll thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants