rearrange args

intake_splunk/__init__.py

@@ -24,9 +24,6 @@ def open(self, query, url, auth, chunksize=5000, **kwargs):
         """
         from intake_splunk.core import SplunkSource
         base_kwargs, source_kwargs = self.separate_base_kwargs(kwargs)
-        query = source_kwargs.pop('query', "")
-        url = source_kwargs.pop('url', "")
-        auth = source_kwargs.pop('auth', tuple())
         return SplunkSource(query, url, auth,
                             metadata=base_kwargs['metadata'],
                             **source_kwargs)

tests/test_intake_splunk.py

@@ -1,16 +1,9 @@
-import os
-
 import pytest
-import pandas as pd
 
+import intake
 from intake_splunk.core import SplunkSource
 from .util import start_splunk, stop_docker
 
-CONNECT = {'host': 'localhost', 'port': 9200}
-TEST_DATA_DIR = os.path.dirname(__file__)
-TEST_DATA = 'sample1.csv'
-df = pd.read_csv(os.path.join(TEST_DATA_DIR, TEST_DATA))
-
 
 @pytest.fixture(scope='module')
 def engine():
@@ -31,3 +24,11 @@ def test_basic(engine):
     c = SplunkSource(test_query, engine, ('admin', 'changeme'), 100)
     d = c.to_dask()
     assert len(d.compute())
+
+
+def test_open(engine):
+    # should always return something
+    test_query = 'index=_internal'
+    c = intake.open_splunk(test_query, engine, ('admin', 'changeme'), 100)
+    d = c.to_dask()
+    assert len(d.compute())