Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video will autoplay even when props.playing is false #10

Closed
cookpete opened this issue Nov 13, 2015 · 1 comment
Closed

Video will autoplay even when props.playing is false #10

cookpete opened this issue Nov 13, 2015 · 1 comment

Comments

@cookpete
Copy link
Owner

Changing the url prop currently autoplays the song you want to load, even if props.playing is false. Autoplay should be disabled and then play called when player is ready only if playing is true.

Or.. set autoplay to the same value as props.playing?
@cookpete cookpete added the bug label Nov 13, 2015
@cookpete
Copy link
Owner Author

Setting autoplay to whatever playing is is probably a bad idea, considering the possibility of playing changing during the SDK and player load sequence.

david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this issue Dec 23, 2018
Remove autoplay and only play if props.playing is true when ready
7797421 
Fixes cookpete/react-player#10
@mgw-sbex mgw-sbex mentioned this issue Jan 25, 2019
Closed
david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this issue May 23, 2020
Remove autoplay and only play if props.playing is true when ready
16dae01 
Fixes cookpete/react-player#10
albanqoku added a commit to albanqoku/react-player that referenced this issue Feb 24, 2021
@albanqoku
Remove autoplay and only play if props.playing is true when ready
b2dcd3d 
Fixes cookpete/react-player#10
Webmaster1116 added a commit to Webmaster1116/video-player that referenced this issue May 20, 2021
@Webmaster1116
Remove autoplay and only play if props.playing is true when ready
f21ce5e 
Fixes cookpete/react-player#10
webmiraclepro added a commit to webmiraclepro/video-player that referenced this issue Sep 9, 2022
@webmiraclepro
Remove autoplay and only play if props.playing is true when ready
79b8842 
Fixes cookpete/react-player#10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cookpete