Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed SoundCloud controls without picture #108

Closed
sedubois opened this issue Oct 3, 2016 · 6 comments
Closed

Embed SoundCloud controls without picture #108

sedubois opened this issue Oct 3, 2016 · 6 comments

Comments

@sedubois
Copy link

sedubois commented Oct 3, 2016

How can a SoundCloud track be embedded with controls but without the big blue placeholder picture (as there's nothing to display)?

@sedubois
Copy link
Author

sedubois commented Oct 4, 2016

SoundCloud URLs accept ?show_artwork=true|false, so this could normally be easily added to soundcloudConfig 😊 It would be an opportunity to add there the various query params they support.

By the way, when providing a soundCloudConfig prop, would be good to make sure the default clientId gets used if none is provided.

@cookpete
Copy link
Owner

cookpete commented Oct 4, 2016

SoundCloud URLs accept ?show_artwork=true|false, so this could normally be easily added to soundcloudConfig 😊 It would be an opportunity to add there the various query params they support.

SoundCloud URLs are just resolved to mp3 URLs and played by FilePlayer, so any query params wouldn't directly work. It would be easy to add a config option to not show any image though.

By the way, when providing a soundCloudConfig prop, would be good to make sure the default clientId gets used if none is provided.

Agreed, the config structure has always been a bit of a problem (hence why I had a go at tidying it up for a future version).

@sedubois
Copy link
Author

sedubois commented Oct 4, 2016

OK I understand. Yes it would be useful to have a mechanism to configure how to display the different attributes (artwork, avatar, title, description, waveform, ...).

@cookpete
Copy link
Owner

cookpete commented Oct 4, 2016

Yes it would be useful to have a mechanism to configure how to display the different attributes (artwork, avatar, title, description, waveform, ...).

This would involve changing ReactPlayer to use the Soundcloud Widget API, which is possible but quite a big change. For now, soundcloud tracks just display the artwork along with standard HTML5 audio controls.

Meanwhile, I've added a showArtwork option to the soundcloudConfig prop that will just display no image when set to false.

@sedubois
Copy link
Author

sedubois commented Oct 9, 2016

Thanks a lot. Do you plan a new release soon? I didn't find a way to depend on GitHub head directly.

@cookpete
Copy link
Owner

Published 0.12.0

In recent versions of npm you can just do npm install cookpete/react-player to depend on the latest commit on github.

david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this issue Dec 23, 2018
david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this issue May 23, 2020
albanqoku added a commit to albanqoku/react-player that referenced this issue Feb 24, 2021
Webmaster1116 added a commit to Webmaster1116/video-player that referenced this issue May 20, 2021
webmiraclepro added a commit to webmiraclepro/video-player that referenced this issue Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants