Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling of YouTube methods before player is ready #20

Closed
cookpete opened this issue Jan 2, 2016 · 1 comment · Fixed by #21
Closed

Better handling of YouTube methods before player is ready #20

cookpete opened this issue Jan 2, 2016 · 1 comment · Fixed by #21

Comments

@cookpete
Copy link
Owner

cookpete commented Jan 2, 2016

@Fauntleroy has found that play() can sometimes be called before this.player.playVideo exists. f18792a prevents errors for the time being, but doesn't really fix the problem.

From this discussion.
cookpete referenced this issue Jan 2, 2016
@cookpete
Use explicit isReady property to guard player methods
ef17dcc 
Fixes #18
@Fauntleroy
Copy link
Contributor

@cookpete I think I found the culprit: this.getSDK() can get called more than once. It's initially called for the blank video load, but it will be called again if you load another video before the SDK finishes loading.

@cookpete cookpete mentioned this issue Jan 2, 2016
Merged
cookpete added a commit that referenced this issue Jan 3, 2016
@cookpete
Handle YouTube URL change during SDK load
f2b1003 
Fixes #20
cookpete added a commit that referenced this issue Jan 3, 2016
@cookpete
Handle YouTube URL change during SDK load
aef79e9 
Fixes #20
cookpete added a commit that referenced this issue Jan 3, 2016
@cookpete
Handle YouTube URL change during SDK load
9f87c88 
Fixes #20
@greggb greggb mentioned this issue Dec 5, 2018
Closed
david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this issue Dec 23, 2018
Handle YouTube URL change during SDK load
666c25e 
Fixes cookpete/react-player#20
@mgw-sbex mgw-sbex mentioned this issue Jan 25, 2019
Closed
david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this issue May 23, 2020
Handle YouTube URL change during SDK load
9db1883 
Fixes cookpete/react-player#20
albanqoku added a commit to albanqoku/react-player that referenced this issue Feb 24, 2021
@albanqoku
Handle YouTube URL change during SDK load
4f8767b 
Fixes cookpete/react-player#20
Webmaster1116 added a commit to Webmaster1116/video-player that referenced this issue May 20, 2021
@Webmaster1116
Handle YouTube URL change during SDK load
740316c 
Fixes cookpete/react-player#20
webmiraclepro added a commit to webmiraclepro/video-player that referenced this issue Sep 9, 2022
@webmiraclepro
Handle YouTube URL change during SDK load
319eb11 
Fixes cookpete/react-player#20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix YouTube onReady bugs cookpete/react-player
2 participants
@Fauntleroy @cookpete