Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird behavior after ended youtube video #271

Closed
hcuong opened this issue Nov 9, 2017 · 1 comment
Closed

Weird behavior after ended youtube video #271

hcuong opened this issue Nov 9, 2017 · 1 comment

Comments

@hcuong
Copy link

hcuong commented Nov 9, 2017 •
edited
Loading

Problem
When a youtube video is ended. We can't replay by clicking play button or youtube play button.

Reproduce in demo app.

  1. Choose an youtube video
  2. Play or seek to the end.
  3. Click play button or youtube play button
  4. The video will not play until we click play again.

It seems that when we click play button youtubeStateChanged send an event pause after that.
I'd thought it related to #265. But when it was closed the problem still happen.
@cookpete
Copy link
Owner

I'm pretty sure this was because the internal isPlaying flag wasn't being set to false when a video ends. Published a fix in the latest 1.0.0 beta so give it a go: npm install react-player@1.0.0-beta.5

david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this issue Dec 23, 2018
Set internal isPlaying flag to false on ended
032e621 
Fixes cookpete/react-player#271
david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this issue May 23, 2020
Set internal isPlaying flag to false on ended
56bd11a 
Fixes cookpete/react-player#271
albanqoku added a commit to albanqoku/react-player that referenced this issue Feb 24, 2021
@albanqoku
Set internal isPlaying flag to false on ended
203aaad 
Fixes cookpete/react-player#271
Webmaster1116 added a commit to Webmaster1116/video-player that referenced this issue May 20, 2021
@Webmaster1116
Set internal isPlaying flag to false on ended
8a95e20 
Fixes cookpete/react-player#271
webmiraclepro added a commit to webmiraclepro/video-player that referenced this issue Sep 9, 2022
@webmiraclepro
Set internal isPlaying flag to false on ended
2f6877d 
Fixes cookpete/react-player#271
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cookpete @hcuong