Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen options #33

Closed
cookpete opened this issue Jan 22, 2016 · 4 comments
Closed

Fullscreen options #33

cookpete opened this issue Jan 22, 2016 · 4 comments

Comments

@cookpete
Copy link
Owner

After seeing @scpaye506's fork that enables fullscreen on Vimeo, I wonder if we should enable fullscreen for Vimeo by default? It could still be overridden back to false via the vimeoConfig prop. If not, I would be inclined to disable fullscreen on YouTube, to align behaviour across players.

Even fullscreen for FilePlayer is possible, but would require controls to be enabled.

Perhaps there is a need for a top level allowFullScreen prop?

@scpaye506
Copy link

I think enabling it by default would be the way to go and then having an option to override. My issue was with how android doesn't open the video into full screen unless allowFullScreen is there, which I feel is expected behavior for users.

@cookpete
Copy link
Owner Author

This is fixed in v0.5.2. Fullscreen is now enabled by default for Vimeo, and can be turned off via config prop:

<ReactPlayer
  url='http://vimeo.com/...'
  vimeoConfig={{ iframeParams: { fullscreen: 0 } }}
/>

david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this issue Dec 23, 2018
Enables fullscreen for Vimeo by default to align with YouTube
Fixes cookpete/react-player#33
@cookpete
Copy link
Owner Author

It looks like this is no longer an option: https://github.com/vimeo/player.js#embed-options

david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this issue May 23, 2020
Enables fullscreen for Vimeo by default to align with YouTube
Fixes cookpete/react-player#33
albanqoku added a commit to albanqoku/react-player that referenced this issue Feb 24, 2021
Enables fullscreen for Vimeo by default to align with YouTube
Fixes cookpete/react-player#33
Webmaster1116 added a commit to Webmaster1116/video-player that referenced this issue May 20, 2021
Enables fullscreen for Vimeo by default to align with YouTube
Fixes cookpete/react-player#33
webmiraclepro added a commit to webmiraclepro/video-player that referenced this issue Sep 9, 2022
Enables fullscreen for Vimeo by default to align with YouTube
Fixes cookpete/react-player#33
@amukkumar
Copy link

How to disable fullScreen for YouTube Videos ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants