Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vimeo link validation not working properly #349

Closed
pawelnvk opened this issue Mar 4, 2018 · 0 comments
Closed

Vimeo link validation not working properly #349

pawelnvk opened this issue Mar 4, 2018 · 0 comments

Comments

@pawelnvk
Copy link

pawelnvk commented Mar 4, 2018

Sharing this video https://vimeo.com/249675407 using Vimeo's share button generates link as follows: https://vimeo.com/yannickcerrutti/annecydroneinmotion, which isn't supported by react-player. I proposed changes to fix this issue in #348
david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this issue Dec 23, 2018
Loosen up the vimeo URL pattern
f7de2b8 
Fixes cookpete/react-player#349
Closes cookpete/react-player#348
david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this issue May 23, 2020
Loosen up the vimeo URL pattern
6dbcaf6 
Fixes cookpete/react-player#349
Closes cookpete/react-player#348
albanqoku added a commit to albanqoku/react-player that referenced this issue Feb 24, 2021
@albanqoku
Loosen up the vimeo URL pattern
9e2df95 
Fixes cookpete/react-player#349
Closes cookpete/react-player#348
Webmaster1116 added a commit to Webmaster1116/video-player that referenced this issue May 20, 2021
@Webmaster1116
Loosen up the vimeo URL pattern
87a9554 
Fixes cookpete/react-player#349
Closes cookpete/react-player#348
webmiraclepro added a commit to webmiraclepro/video-player that referenced this issue Sep 9, 2022
@webmiraclepro
Loosen up the vimeo URL pattern
ca0eb34 
Fixes cookpete/react-player#349
Closes cookpete/react-player#348
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pawelnvk