Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minified / concatenated js #35

Closed
ioRekz opened this issue Jan 27, 2016 · 2 comments
Closed

minified / concatenated js #35

ioRekz opened this issue Jan 27, 2016 · 2 comments

Comments

@ioRekz
Copy link

ioRekz commented Jan 27, 2016

Hi, I'm trying to build a minified version of react player so I can use it from clojurescript.

I'm not familiar with buildpack so I'm not sure how I should do it from the sources.

@cookpete
Copy link
Owner

Hey @ioRekz, see the library branch I just pushed with a commit to try and solve this. You should be able to npm run build:browser that creates dist/ReactPlayer.js, which just does var ReactPlayer = function(){...}.

Does this do the trick? If so I will tidy it up a bit and merge it in. I'm not familiar with clojurescript so I'm not sure exactly what output you need.

@ioRekz
Copy link
Author

ioRekz commented Jan 29, 2016

I'm trying out today, that should be ok thx !

On Thu, Jan 28, 2016 at 3:26 PM, Pete Cook notifications@github.com wrote:

Hey @ioRekz https://github.com/ioRekz, see the library
https://github.com/CookPete/react-player/tree/library branch I just
pushed with a commit
11197a6
to try and solve this. You should be able to npm run build:browser that
creates dist/ReactPlayer.js, which just does var ReactPlayer =
function(){...}.

Does this do the trick? If so I will tidy it up a bit and merge it in. I'm
not familiar with clojurescript so I'm not sure exactly what output you
need.


Reply to this email directly or view it on GitHub
#35 (comment)
.

@cookpete cookpete mentioned this issue Feb 9, 2016
david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this issue Dec 23, 2018
Run `npm run build:browser` to create a standalone js file in `dist`
Resolves cookpete/react-player#35
Also fully resolves cookpete/react-player#38
david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this issue May 23, 2020
Run `npm run build:browser` to create a standalone js file in `dist`
Resolves cookpete/react-player#35
Also fully resolves cookpete/react-player#38
albanqoku added a commit to albanqoku/react-player that referenced this issue Feb 24, 2021
Run `npm run build:browser` to create a standalone js file in `dist`
Resolves cookpete/react-player#35
Also fully resolves cookpete/react-player#38
Webmaster1116 added a commit to Webmaster1116/video-player that referenced this issue May 20, 2021
Run `npm run build:browser` to create a standalone js file in `dist`
Resolves cookpete/react-player#35
Also fully resolves cookpete/react-player#38
webmiraclepro added a commit to webmiraclepro/video-player that referenced this issue Sep 9, 2022
Run `npm run build:browser` to create a standalone js file in `dist`
Resolves cookpete/react-player#35
Also fully resolves cookpete/react-player#38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants