Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console errors when using component for twitch stream #358

Closed
pedropcruz opened this issue Mar 16, 2018 · 11 comments
Closed

console errors when using component for twitch stream #358

pedropcruz opened this issue Mar 16, 2018 · 11 comments

Comments

@pedropcruz
Copy link

Hello there,

I' m trying to put my component with url and with some options on twitch, and have this error:

image

How i can solve this? Many thanks!

@hellojere
Copy link

Same with Vimeo direct URL's. Reverting back to 1.2.1 works.

@cookpete
Copy link
Owner

@pedropcruz @hellojere What URL/props are you using to cause this error? Examples code/repos/jsFiddles are very useful.

@hellojere
Copy link

@cookpete Happens with the react-player demo too when using the following for the source:

https://player.vimeo.com/external/134290208.sd.mp4?s=9000cee9e39cb10a907c297ec36bcde452dfb9e5&profile_id=112

@pedropcruz
Copy link
Author

pedropcruz commented Mar 21, 2018

@cookpete in my case just showing doing this:

<ReactPlayer className="react-player"  url="https://www.twitch.tv/pedropcruz"
                        config={{
                            twitch:{
                                options:{
                                    'font-size':'small',
                                    channel: 'pedropcruz',
                                    chat: 'default',
                                    layout: 'video-and-chat',
                                    theme: 'dark',
                                    src: 'https://www.twitch.tv/pedropcruz/chat'
                                }
                            }
                        }}
/>

@cookpete
Copy link
Owner

@pedropcruz your config is working correctly for me? See jsFiddle.

After a closer look at your screenshot, it looks like it could be an adblock extension that is preventing sdkloader from loading, which may be preventing the Twitch SDK from being loaded.

@hellojere this looks like a separate issue where the Vimeo player is attempting to play your MP4 file, as the URL for the file contains vimeo.com.

@hellojere
Copy link

hellojere commented Mar 22, 2018

@cookpete Hmmn. Ok. It indeed should be playing an MP4 and not embedding a Vimeo player at all - it's a direct file URL provided by Vimeo Pro. I'll look into other solutions for this. Cheers.

@pedropcruz
Copy link
Author

nop @cookpete already remove adblock and other type of that extension, and the error continues the same.

@cookpete
Copy link
Owner

already remove adblock and other type of that extension, and the error continues the same.

@pedropcruz What are the exact console errors you are seeing with adblock disabled?

david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this issue Dec 23, 2018
@nkane
Copy link

nkane commented Dec 31, 2018

I seem to be receiving a similar error without the chat rendering

image

this is my render call:

image

even with a src added, it still errors out at a window.appendChild function call.

@cookpete
Copy link
Owner

cookpete commented Jan 1, 2019

Just had a closer look – you guys are trying to use options for the Embed Everything player like chat, layout and theme. Currently ReactPlayer uses the Interactive Frame player, which uses fewer options.

I'll see if it makes sense to switch over to use Twitch.Embed() for everything rather than Twitch.Player() – perhaps using Twitch.Embed() only if certain options are set.

@cookpete cookpete reopened this Jan 1, 2019
@cookpete
Copy link
Owner

Turns out that Twitch.Embed() doesn't quite work for us as it only has events for ready and play. I think the solution here is to only embed the video, and embed the chat window separately by following the Twitch docs.

david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this issue May 23, 2020
albanqoku added a commit to albanqoku/react-player that referenced this issue Feb 24, 2021
Webmaster1116 added a commit to Webmaster1116/video-player that referenced this issue May 20, 2021
webmiraclepro added a commit to webmiraclepro/video-player that referenced this issue Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants