Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single FilePlayer does not respect file forceDASH config #500

Closed
Obi-Dann opened this issue Oct 16, 2018 · 0 comments
Closed

Single FilePlayer does not respect file forceDASH config #500

Obi-Dann opened this issue Oct 16, 2018 · 0 comments

Comments

@Obi-Dann
Copy link

Obi-Dann commented Oct 16, 2018 •
edited
Loading

In order to reduce the bundle size, I am keen on using SinglePlayer for FilePlayer.
However, the player behaves differently from the "normal" player and does not work as a drop in replacement.
I think the problem is with FilePlayer.canPlay method that does not respect fileConfig settings, eg forceDASH.
It seems that "normal" ReactPlayer works because it 'fallsback' to FilePlayer
https://github.com/CookPete/react-player/blob/c50320a51ff152bfe8e1b01f9e17195da496c42c/src/ReactPlayer.js#L68-L76

What do you think about removing canPlay check from SinglePlayer ?https://github.com/CookPete/react-player/blob/c50320a51ff152bfe8e1b01f9e17195da496c42c/src/singlePlayer.js#L47-L49

There's a codesandbox example showcasing the bug:
https://codesandbox.io/s/mm2oyppzx8
david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this issue Dec 23, 2018
Prevent singlePlayer from returning null when forcing via config
87d291c 
Fixes cookpete/react-player#500
david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this issue May 23, 2020
Prevent singlePlayer from returning null when forcing via config
faebb7c 
Fixes cookpete/react-player#500
albanqoku added a commit to albanqoku/react-player that referenced this issue Feb 24, 2021
@albanqoku
Prevent singlePlayer from returning null when forcing via config
862fa2a 
Fixes cookpete/react-player#500
Webmaster1116 added a commit to Webmaster1116/video-player that referenced this issue May 20, 2021
@Webmaster1116
Prevent singlePlayer from returning null when forcing via config
81c7dcd 
Fixes cookpete/react-player#500
webmiraclepro added a commit to webmiraclepro/video-player that referenced this issue Sep 9, 2022
@webmiraclepro
Prevent singlePlayer from returning null when forcing via config
a53a9fd 
Fixes cookpete/react-player#500
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Obi-Dann