Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pausing video does not clear the onProgress timeOut #51

Closed
whitegrey opened this issue Apr 11, 2016 · 1 comment
Closed

Pausing video does not clear the onProgress timeOut #51

whitegrey opened this issue Apr 11, 2016 · 1 comment

Comments

@whitegrey
Copy link

Mostly a visual issue, but when pausing the video, there will often be another "tick" of the seek bar since the onProgress timeOut isn't cleared.

@cookpete
Copy link
Owner

The timeout is deliberately not cleared, because we might still want to get updates to the loaded percentage even when paused. Perhaps two progress callback props are needed instead, like playProgress and loadProgress.

Or, an easier fix would be just to check for this.props.playing here, which would just not include the played property if the media is paused.

cookpete added a commit that referenced this issue Jul 27, 2016
To prevent the delayed progress event after pausing, and ensure #51 doesn't happen again
cookpete added a commit that referenced this issue Sep 23, 2016
cookpete added a commit that referenced this issue Sep 25, 2016
david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this issue Dec 23, 2018
david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this issue Dec 23, 2018
david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this issue May 23, 2020
david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this issue May 23, 2020
albanqoku added a commit to albanqoku/react-player that referenced this issue Feb 24, 2021
albanqoku added a commit to albanqoku/react-player that referenced this issue Feb 24, 2021
Webmaster1116 added a commit to Webmaster1116/video-player that referenced this issue May 20, 2021
Webmaster1116 added a commit to Webmaster1116/video-player that referenced this issue May 20, 2021
webmiraclepro added a commit to webmiraclepro/video-player that referenced this issue Sep 9, 2022
webmiraclepro added a commit to webmiraclepro/video-player that referenced this issue Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants