Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vimeo video with password doesn't have duration or get progress events #514

Closed
grant-davidson opened this issue Nov 6, 2018 · 0 comments

Comments

@grant-davidson
Copy link

grant-davidson commented Nov 6, 2018

When a password protected Vimeo video is opened, the password entry field is displayed as expected.

However, after the password is entered and the video shows and is then played, the video duration isn't set.

This means that progress events aren't dispatched by react-player.

There are at least 2 fixes that could be applied:

  1. Change the progress function in Player.js to send progress events even if duration is zero (progress.playSeconds & progress.loadedSeconds would still contain useful information).
  2. If duration is not set when "play" and "seekTo" in Vimeo are called, call player.getDuration to set the duration before calling onPlay or setCurrentTime.

Would a pull request with one of these fixes be the way forward?

Fix 2 above seems more complete as duration as well as progress events is now available.

Thanks

david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this issue Dec 23, 2018
Previously, duration was only set on `loaded`, which returns 0 if the video is password protected
Fixes cookpete/react-player#514
david-hub024 added a commit to david-hub024/React_VideoPlayer that referenced this issue May 23, 2020
Previously, duration was only set on `loaded`, which returns 0 if the video is password protected
Fixes cookpete/react-player#514
albanqoku added a commit to albanqoku/react-player that referenced this issue Feb 24, 2021
Previously, duration was only set on `loaded`, which returns 0 if the video is password protected
Fixes cookpete/react-player#514
Webmaster1116 added a commit to Webmaster1116/video-player that referenced this issue May 20, 2021
Previously, duration was only set on `loaded`, which returns 0 if the video is password protected
Fixes cookpete/react-player#514
webmiraclepro added a commit to webmiraclepro/video-player that referenced this issue Sep 9, 2022
Previously, duration was only set on `loaded`, which returns 0 if the video is password protected
Fixes cookpete/react-player#514
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant