Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few features of the player does not work for Vimeo/Youtube #560

Closed
ljairath opened this issue Jan 27, 2019 · 2 comments
Closed

Few features of the player does not work for Vimeo/Youtube #560

ljairath opened this issue Jan 27, 2019 · 2 comments

Comments

@ljairath
Copy link

Following features did not work for me.

Vimeo: Controls, Loop, Fullscreen
Youtube: Fullscreen, Controls work except that Youtube icon is displayed.

@scharissis
Copy link

@ljairath have you tried enabling modestbranding to not show the YouTube icon/logo?

<ReactPlayer
                      url='https://www.youtube.com/watch?v=mFJZ0HaYYB8'
                      config={{
                        youtube: {
                          playerVars: { modestbranding: 1 }
                        }
                      }}
                    />

cookpete added a commit that referenced this issue Jan 27, 2019
Also fix MixCloud looping
Partly fixes #560
@cookpete
Copy link
Owner

There's quite a few unspecific problems pointed out here so I'll try and break it down:

Vimeo controls

The Vimeo player has no support for setting controls, so this is not supported. This is noted in the readme under the controls prop.

If you are a Vimeo Plus, PRO, or Business member, you can use config.vimeo.playerOptions to set background: true which will "Enable the player's background mode which hides the controls, autoplays and loops the video".

Vimeo loop

I assume you are referring to toggling loop after a Vimeo video has started playing. This is fixed in 1.9.2.

Vimeo fullscreen and Youtube fullscreen

I assume you are referring to the Fullscreen function in the demo app on latest Chrome, which was broken due to the Fullscreen API changing. This should now be fixed in the demo app (by upgrading to latest screenfull.js). Other than this, all fullscreen functionality seems to be working correctly.

Youtube controls work except that Youtube icon is displayed

I'm not sure what the problem is here. With default props (which includes playerVars: { modestbranding: 1 } as @scharissis mentioned), the youtube icon only shows when controls is false when hovering over the player:

image

When controls is true, the controls show, but no Youtube icon:

image


If there's anything I've not fixed or explained here that still isn't working as expected. Feel free to open a new issue (or reopen this one) with a clear description of the problem.

albanqoku added a commit to albanqoku/react-player that referenced this issue Feb 24, 2021
albanqoku added a commit to albanqoku/react-player that referenced this issue Feb 24, 2021
Also fix MixCloud looping
Partly fixes cookpete/react-player#560
Webmaster1116 added a commit to Webmaster1116/video-player that referenced this issue May 20, 2021
Webmaster1116 added a commit to Webmaster1116/video-player that referenced this issue May 20, 2021
Also fix MixCloud looping
Partly fixes cookpete/react-player#560
webmiraclepro added a commit to webmiraclepro/video-player that referenced this issue Sep 9, 2022
webmiraclepro added a commit to webmiraclepro/video-player that referenced this issue Sep 9, 2022
Also fix MixCloud looping
Partly fixes cookpete/react-player#560
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants