Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use HTML5 audio for SoundCloud tracks #64

Closed
cookpete opened this issue May 20, 2016 · 1 comment
Closed

Use HTML5 audio for SoundCloud tracks #64

cookpete opened this issue May 20, 2016 · 1 comment

Comments

@cookpete
Copy link
Owner

After #24 (comment), it looks like we can stop dealing with the SoundCloud SDK completely and just add the stream_url we get from the SC endpoint to an <audio> element, something we already do with filePlayer
@denisflorkin
Copy link

Hello, I managed to get something working that pretty much empty SoundCloud of all its code and have it inherit from FilePlayer, as you suggested.
The test are passing (in chrome only thought).
So here it is : #65

cookpete added a commit that referenced this issue May 21, 2016
@cookpete
Use filePlayer for SoundCloud tracks
68e5afc 
Fixes #64
david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this issue Dec 23, 2018
Use filePlayer for SoundCloud tracks
b3133aa 
Fixes cookpete/react-player#64
david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this issue May 23, 2020
Use filePlayer for SoundCloud tracks
3284266 
Fixes cookpete/react-player#64
albanqoku added a commit to albanqoku/react-player that referenced this issue Feb 24, 2021
@albanqoku
Use filePlayer for SoundCloud tracks
48cbb19 
Fixes cookpete/react-player#64
Webmaster1116 added a commit to Webmaster1116/video-player that referenced this issue May 20, 2021
@Webmaster1116
Use filePlayer for SoundCloud tracks
94acbec 
Fixes cookpete/react-player#64
webmiraclepro added a commit to webmiraclepro/video-player that referenced this issue Sep 9, 2022
@webmiraclepro
Use filePlayer for SoundCloud tracks
a9b4fe3 
Fixes cookpete/react-player#64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cookpete @denisflorkin