Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StrictMode warnings for unsafe lifecycle methods #651

Closed
rares-lupascu opened this issue May 23, 2019 · 1 comment
Closed

StrictMode warnings for unsafe lifecycle methods #651

rares-lupascu opened this issue May 23, 2019 · 1 comment

Comments

@rares-lupascu
Copy link

Be sure to search for your issue before opening a new one.

Current Behavior

Warning: Unsafe lifecycle methods were found within a strict-mode tree:
    in StrictMode (at src/index.tsx:54)

componentWillReceiveProps: Please update the following components to use static getDerivedStateFromProps instead: Player

componentWillUpdate: Please update the following components to use componentDidUpdate instead: ReactPlayer

Expected Behavior

No warning :)

Steps to Reproduce

  1. Add the player under <React.StrictMode>

Environment

  • URL attempting to play: n/a
  • Browser: n/a
  • Operating system: n/a
  • jsFiddle example: no need

Other Information

n/a

@jaytula
Copy link

jaytula commented Aug 14, 2019

I've created a pull request #692 implement the two instances of componentWillUpdate as componentDidUpdate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants