Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong twitch channel regex (allows only lower letters) #860

Closed
kamparR opened this issue Apr 26, 2020 · 1 comment
Closed

Wrong twitch channel regex (allows only lower letters) #860

kamparR opened this issue Apr 26, 2020 · 1 comment

Comments

@kamparR
Copy link

kamparR commented Apr 26, 2020

Hi,
in src/patterns.js there is:
export const MATCH_URL_TWITCH_CHANNEL = /(?:www\.|go\.)?twitch\.tv\/([a-z0-9_]+)($|\?)/

and as you can see in regex there is only support for lower letter a-z and not also for upper A-Z
It can be tested using demo site, eg. using first url twitch.tv/myth and then twitch.tv/Myth. Only first one will work.
@cookpete
Copy link
Owner

Fixed in v2.0.1

albanqoku added a commit to albanqoku/react-player that referenced this issue Feb 24, 2021
@albanqoku
Match twitch channel pattern case-insensitive
2b74a89 
Fixes cookpete/react-player#860
Webmaster1116 added a commit to Webmaster1116/video-player that referenced this issue May 20, 2021
@Webmaster1116
Match twitch channel pattern case-insensitive
50312b5 
Fixes cookpete/react-player#860
webmiraclepro added a commit to webmiraclepro/video-player that referenced this issue Sep 9, 2022
@webmiraclepro
Match twitch channel pattern case-insensitive
db8f66f 
Fixes cookpete/react-player#860
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cookpete @kamparR