Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

youtube-nocookie.com isn't recognized as a youtube link #896

Closed
vmenard17 opened this issue May 22, 2020 · 1 comment
Closed

youtube-nocookie.com isn't recognized as a youtube link #896

vmenard17 opened this issue May 22, 2020 · 1 comment

Comments

@vmenard17
Copy link

vmenard17 commented May 22, 2020 •
edited
Loading

Current Behavior

When I add a youtube video with this url :
https://www.youtube-nocookie.com/embed/8xV95bSyHYk
React player doesn't recognize this url as a valid youtube link.

Expected Behavior

Fix regex MATCH_URL_YOUTUBE to accept https://www.youtube-nocookie.com/embed/
https://github.com/CookPete/react-player/blob/32bb251a60f1a6449bd20e6dcf4c7dbfaeab02b7/src/patterns.js#L1

Steps to Reproduce

  1. Add this url to player : https://www.youtube-nocookie.com/embed/8xV95bSyHYk

Environment

Thanks
@vmenard17
Copy link
Author

Thanks @cookpete

@matiasilva matiasilva mentioned this issue Jun 11, 2020
Closed
Webmaster1116 added a commit to Webmaster1116/video-player that referenced this issue May 20, 2021
@Webmaster1116
Support youtube-nocookie.com
28aa7c9 
Fixes cookpete/react-player#896
Thoroughly fixes cookpete/react-player#272
Thoroughly fixes cookpete/react-player#557
webmiraclepro added a commit to webmiraclepro/video-player that referenced this issue Sep 9, 2022
@webmiraclepro
Support youtube-nocookie.com
3623ceb 
Fixes cookpete/react-player#896
Thoroughly fixes cookpete/react-player#272
Thoroughly fixes cookpete/react-player#557
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vmenard17