Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading issue on iPad Pro only ("request desktop site") #1004

Closed
taitems opened this issue Sep 2, 2020 · 0 comments
Closed

Loading issue on iPad Pro only ("request desktop site") #1004

taitems opened this issue Sep 2, 2020 · 0 comments

Comments

@taitems
Copy link

taitems commented Sep 2, 2020

TL;DR - The isIOS check is out of date and doesn't handle iPad Pro in desktop mode.

Current Behavior

If you navigate to a video shown by react-player on an iPad Pro specifically, it never passes loading to fire the onReady event. Looking at the network tab you will see a red 206 Partial Content instead of the normal green 206.

In our use case where we show a spinner tied to loading, it never goes away.

By default the iPad Pro is requesting the desktop site.

  • iPad Pro “request desktop site” user agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.0.5 Safari/605.1.15
  • iPad Pro “request mobile site” user agent: Mozilla/5.0 (iPad; CPU OS 13_3_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.0.5 Mobile/15E148 Safari/604.1

Expected Behavior

Video loads but still needs to be clicked to play, as other issues have noted due to changing iOS autoplay settings.

Steps to Reproduce

  1. Navigate to a page in an iPad Pro
  2. Ensure it is in "desktop mode"
  3. Video will not load
  4. "Request mobile mode"
  5. Note the video will now loads successfully

Environment

  • Behind an auth wall unfortunately.

Other Information

Webmaster1116 added a commit to Webmaster1116/video-player that referenced this issue May 20, 2021
webmiraclepro added a commit to webmiraclepro/video-player that referenced this issue Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant