-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Soundcloud implementation with SC.stream to avoid focus problems #262
Conversation
What is the benefit of using the streaming SDK over the iframe widget? The title of the PR mentions "focus problems" but you haven't specified exactly what problems there are. The library has already switched from using the SDK to the widget in the past because of issues with the client ID and rate limiting, along with the fact that signing up for your own client ID is currently unavailable. |
Focus problem :
I use serveral kind of provider on my website.
When I play a track and the next one does not use the same provider, for
example from youtube to soundcloud, if the window is not focused at the
moment the track won't play.
I suspected that the library made a switch in the past : I went back to
check but I guess I didn't go far enough.
I have a client_id. I'll just keep this version of the code as a fork and
use it in my own project and update to follow the evolution of your repo.
…On Mon, Oct 30, 2017 at 9:11 AM, Pete Cook ***@***.***> wrote:
What is the benefit of using the streaming SDK over the iframe widget? The
title of the PR mentions "focus problems" but you haven't specified exactly
what problems there are.
The library has already switched from using the SDK to the widget in the
past because of issues with the client ID and rate limiting, along with the
fact that signing up for your own client ID is currently unavailable
<http://soundcloud.com/you/apps/new>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#262 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAO2RK7TKzHjdwhDe_VOOpfcBUA4E31tks5sxcr1gaJpZM4QLHAu>
.
--
Adrien Candiotti
login : candio_a
epitech 2013 - astek - koala
|
Ah this is exactly what the |
Yes, exactly, I assumed that if it wasn't implemented it was because it
wasn't working or something like that.
Next time i'll ask before I code something like that.
It wasn't a loss of time though : i got to dig into the internals a bit more.
By the way : should i open an issue for the bug i found?
Ok great! Thanks :)
Let me know if you need hands to try that
…On Mon, Oct 30, 2017 at 9:30 AM, Pete Cook ***@***.***> wrote:
Closed #262 <#262>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#262 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAO2RNRSkrKyCN84ynPwBezZGrU-Ov1Jks5sxc9jgaJpZM4QLHAu>
.
--
Adrien Candiotti
login : candio_a
epitech 2013 - astek - koala
|
No need: fixed and published in |
might not be perfect but it's a start.
difference with the previous soundcloud implementation:
SDK choice :
https://connect.soundcloud.com/sdk.js is an old 2.0 version, no promises
https://connect.soundcloud.com/sdk/sdk-3.2.2.js asks for a secret_token
3.0.0 was kept
BUG FOUND:
bug found at src/Player.js : this.onPause is not given as a parameter to the active Player:
When i paused my player i could not play it back.
i noticed that the internal
isPlaying
variable wasn't updated.Ultimately it was the onPause callback that wasn't passed back to
the Player in the render function.
Adding it fixed my problem