Update SoundCloud regex to match Sets #324
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
In fact, maybe we should change the pattern to just /(soundcloud.com|snd.sc)\/.+$/Because we may as well send any soundcloud URL to the widget and let it error if invalid, rather than falling back to trying to play it in a |
|
Yes, good call. Thanks! |
david-hub024
pushed a commit
to david-hub024/React_VideoPlayer
that referenced
this pull request
Dec 23, 2018
We may as well send any soundcloud URL to the widget and let it error if invalid, rather than falling back to FilePlayer. Fixes cookpete/react-player#322 Closes cookpete/react-player#324
david-hub024
pushed a commit
to david-hub024/React_VideoPlayer
that referenced
this pull request
May 23, 2020
We may as well send any soundcloud URL to the widget and let it error if invalid, rather than falling back to FilePlayer. Fixes cookpete/react-player#322 Closes cookpete/react-player#324
albanqoku
added a commit
to albanqoku/react-player
that referenced
this pull request
Feb 24, 2021
We may as well send any soundcloud URL to the widget and let it error if invalid, rather than falling back to FilePlayer. Fixes cookpete/react-player#322 Closes cookpete/react-player#324
Webmaster1116
added a commit
to Webmaster1116/video-player
that referenced
this pull request
May 20, 2021
We may as well send any soundcloud URL to the widget and let it error if invalid, rather than falling back to FilePlayer. Fixes cookpete/react-player#322 Closes cookpete/react-player#324
webmiraclepro
added a commit
to webmiraclepro/video-player
that referenced
this pull request
Sep 9, 2022
We may as well send any soundcloud URL to the widget and let it error if invalid, rather than falling back to FilePlayer. Fixes cookpete/react-player#322 Closes cookpete/react-player#324
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #322