Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Proposed solutions to the Firefox Container Tabs unexpected localStorage cleanup #1576

Open
1 task done
WAZAAAAA0 opened this issue Jun 9, 2023 · 3 comments

Comments

@WAZAAAAA0
Copy link

WAZAAAAA0 commented Jun 9, 2023

Acknowledgements

  • I acknowledge that I have read the above items

Is your feature request related to a problem? Please describe.

So here's the problem in a nutshell that's been encountered by users numerous times (#211 #347 #952 #1395 #1427 #1468 etc.)

  • deleting cookies of website X only on 1 container: works
  • deleting localStorage of website X only on 1 container: doesn't work, all containers deleted
  • bad workaround: disable localStorage cleaning entirely and never ever let the extension touch them :-(
  • better workaround: whitelist website X on all containers and not just 1

As far as I know this localStorage flaw also applies to the other storage types: Cache, IndexedDB, Plugin Data, Service workers... EXCEPT COOKIES which behave correctly. This is due to WebExtension API limitations as stated here #1395 (comment)

Describe the solution that you'd like

Until the Firefox devs implement it properly, some safeguards can be tried to limit that frustrating global cleanup:
SOLUTION 1: when container support is enabled, pressing the + Whitelist button should add the rule to ALL containers instead of just 1
SOLUTION 2: this was proposed by @SpaceClicker here and it's probably a more elegant solution #1427 (comment) basically add a check that goes something like this: if www.example.com localStorage whitelist rule exists in ANY container -> DO NOT cleanup

The idea is that if the user went out of his way to WHITELIST a website on 1 container, it's better user experience to be overcautious and let that data survive on all containers than it is to be too overzealous and delete that data on all containers.

@Exagone313
Copy link

I don't understand the workarounds you propose.

Currently, if I have LocalStorage Cleanup, I have a host allowed that still has its local storage cleaned up at a random time. I tried allowing the host in the default container, but it still happens.

I have to keep this setting disabled until the extension is fixed, but this doesn't block tracking using local storage on other websites.

@WAZAAAAA0
Copy link
Author

I don't understand the workarounds you propose.

I tried allowing the host in the default container, but it still happens.

Almost there; you need to allow the host in EACH container (Default, Personal, Work, Banking, Shopping etc.)

@Exagone313
Copy link

Exagone313 commented Apr 15, 2024

It seems like I have another extension that removes my local storage, because even when LocalStorage Cleanup is disabled, my keys are still getting removed. Or CAD is misbehaving. I'll make more tests.

EDIT: I had Firefox set to remove offline data when it closes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants