Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug/Feature Requests]- Can't Download Videos #215

Closed
Jpersh27 opened this issue Feb 10, 2021 · 18 comments
Closed

[Bug/Feature Requests]- Can't Download Videos #215

Jpersh27 opened this issue Feb 10, 2021 · 18 comments
Labels
bug Something isn't working P2: Medium priority Needs to be fixed eventually

Comments

@Jpersh27
Copy link

Jpersh27 commented Feb 10, 2021

[Bug]-

• No videos can be downloaded from the following NSFW websites: xhamster.com, pornhub.com, or xvideos.com.

• No option within the browser to long press on a particular video and a pop up appears saying “Save" or ”Download" Video.

• I have the “Smart Cookie Download Manager" turned on under the “Advanced Settings" tab within the browser settings.

[Device information]-

• Smart Cookie Web Version # 12.1.1 Installed from GitHub.

• My Device is currently running- Android 10 Q.

[Feature Requests]-

1.) I would like to see a Video Grabber or a Universal File Downloader function made available within the browser.

• (Or the ability to Long press on a video and a download or save video option pops up on the screen allowing you the ability to name the file or simply just download right away)

2.) I would also like to see support for Adblocker Filters added to the browser. (Host files are not entirely effective in blocking all ads and trackers compared to traditional Adblocker filters)

@Jpersh27 Jpersh27 added P2: Medium priority Needs to be fixed eventually bug Something isn't working labels Feb 10, 2021
@CookieJarApps
Copy link
Owner

Thanks for the suggestion / bug report. Video downloading is definitely something I'll work on for update v13, and a more traditional adblocker is in development at the branch https://github.com/CookieJarApps/SmartCookieWeb/tree/libadblockplus - I'm hoping to have a beta available for it this week.

@Jpersh27
Copy link
Author

@CookieJarApps You are welcome, and I do have 4 quick questions for you if you have time to answer them please.

1.) Firstly, Is the more traditional Adblocker feature going to be available sometime this week as you stated above? (In Beta Form)

2.) How long before you expect a “update v13" of the browser to be released in Beta?

3.) Do you already have an idea of how you will improve the download functionality or ability to save Videos within the browser?

4.) Lastly, is there any way to download Videos right now from the specific NSFW sites I mentioned above?
(With the use of the built in download manager currently available within the browser)

Thanks again!

@CookieJarApps
Copy link
Owner

Sure,

  1. Yes, it's 99% done so on Friday or Saturday I'll release a beta - there will be 3 ad block modes (hybrid, elements and hosts), the hosts option is the current adblocker, elements is an adblockplus-based adblocker that uses easylist with acceptable ads also removed by default, and hybrid uses both together to be about on par with uBlock origin. The main issue at the moment is that on some sites, the two adblockers conflict and the app crashes so I'm working on making sure that they both work perfectly.

  2. Usually each update is released every month, but usually the first beta is done after the first 1-2 weeks, so possibly this weekend but most likely next weekend (20th of Feb).

  3. Either I'll make it as easy as an image (e.g. just hold on the video and press download - I'll just need to add support for sites that don't just use the default HTML5 video player), or I'll do something similar to 1DM with a download button that lists all the videos on the site and lets you download them at various resolutions.

  4. At the moment, it seems like the built in download manager struggles with video downloads, especially videos that don't use the default player, so it's definitely something that I'll need to improve.

@Jpersh27
Copy link
Author

Jpersh27 commented Feb 12, 2021

@CookieJarApps Thank you for the reply and extensive explanation.

• I do have 2 final questions if you have the time to answer them please. Thanks again.

1.) Will the beta that will most likely arrive next weekend (20th of Feb) include the added improvements to the Video download functionality? Or will it be pushed back to a later date?

• (I feel either way would work but coming from experience as being a current user of IDM+ I feel as though that IDM+ gets it right and does it effectively on almost all websites that host videos)

2.) Any plans to include an element zapper/picker to the Adblocker?

• (Similar to uBlock origin on desktop. In which the zapper just stops the Ads from appearing for the duration of your session on the website. However, if you use the picker you are able to pick the specific Ad in question on your screen and a rule is added to the Adblocker preventing that element from reappearing in the future)

@CookieJarApps
Copy link
Owner

  1. Yes, the beta will include improved video downloading

  2. There aren't any plans at the moment, but it's a uBlock feature I like a lot, so I'll add it to the roadmap

@Jpersh27
Copy link
Author

@CookieJarApps Thanks again for the info and looking forward to testing out the beta build next weekend.
• I have two final questions for you below if you have time to answer them for me please.

1.) Have you settled yet on what Video download function you'll be using?

• “Either the option too simply just hold on the video and press download" Or “Something similar to 1DM with a download button that lists all the videos on the site and lets you download them at various resolutions"

2.) Will the beta version next weekend be released in the Normal “SmartCookieWeb" Repository? Or will it be released in the “SmartCookieWeb-beta" Repository on GitHub?

Thanks again and have a nice rest of your weekend.

@CookieJarApps
Copy link
Owner

CookieJarApps commented Feb 14, 2021

1) I still haven't 100% decided, but probably the 1DM solution - I'm just not really sure where I'd put the download button, but the actual feature would be pretty easy to implement using YouTubeDL (assuming it doesn't increase the app size too much, and doesn't get the app removed from the Play Store)

  1. The beta will be on the SmartCookieWeb-beta repository (they're in a different repo so F-Droid doesn't see them as full releases, and they have a different package name)

Edit: I just checked, publishing an app using YouTubeDL will probably result in the app being removed. I'll still add the feature but I'll probably have to block its functionality on some sites in the Play Store version.

Edit 2: Ok, YouTubeDL will also increase the APK size by 10MB. What I'm going to do is make a separate app that you can download the APK for and it adds video download functionality.

@Jpersh27
Copy link
Author

Jpersh27 commented Feb 14, 2021

@CookieJarApps Thanks for the reply again.

•Suggestion- A good place for the download button could be between the "Refresh Button" in the address bar and the “3 vertical dots button aka vertical ellipsis."

•1DM has it located exactly between both of those buttons. I will include a screenshot showing the location I'm describing.

• I currently am using the most current version released on the SmartCookieWeb repository on GitHub and only plan on installing the ones available on GitHub opposed to using the Google Play store version.

1.) Do I have to reinstall the browser and install the current Beta version located in the SmartCookieWeb-beta repository? Or will I be able to just simply update the browser by installing the new beta version when available?

2.) Would the download manager work the same way or in a similar way as 1DM works?

• Which lists all available videos on the page and allow you to select the resolution you want for the video.

IMG_20210214_052523.jpg

@CookieJarApps
Copy link
Owner

  1. The beta version will install as a separate app - you don't need to uninstall the main app and it won't overwrite it either, so if something goes wrong in the beta you can still use the browser.

  2. The downloader will work in the same way as 1DM (and will be compatible with YouTube, unlike 1DM), but to avoid Google Play restrictions it'll be a separate app. So you'll install the browser and a video downloader plugin alongside it, which will enable the video downloading functionality and will mean that it won't increase the size of the main app.

@Jpersh27
Copy link
Author

Jpersh27 commented Feb 14, 2021

@CookieJarApps- Thanks again for the reply.

• So from what I'm gathering is that I need to install the beta version of the app under the sperate repository here on GitHub, and then once you release a new update I will be able to install the video downloader plugin under the extension tab under settings within the browser?

• Beta Repository- https://github.com/CookieJarApps/SmartCookieWeb-beta/releases

1.) Exactly like in the screenshot I attached here below?

2.) Will the Video download function only be coming to the Beta version of the browser? Or will it eventually come to the stable (Normal) version of the browser? (Just not the Google Play version of it I assume)

3.) Lastly is the beta build still on track to release by next weekend (19th-21st)? Or will it releases earlier on in the week (15th-19th)?

• Thanks again.

Screenshot_20210214-151117.jpg

@CookieJarApps
Copy link
Owner

CookieJarApps commented Feb 14, 2021

So the way it will work is, if you have the beta of update v13 installed and the plugin app installed, the browser will automatically start showing a download icon in the toolbar when you visit a site with a compatible video on it. The functionality will come to the stable version of the browser when v13 comes out fully, and the Play Store version will have support too (but the plugin APK would have to be sideloaded).

Older app versions will support the plugin as well, but you have to open the menu and use the share option to share the page with the plugin, so it's not as simple as one button.

I'm hoping to release the first version of the plugin in the next 2-3 days.

Here's a screenshot of how the app will look when you open a video for download:
Screenshot_20210214-203141.jpg

And here's a list of sites that video download will work on: https://github.com/ytdl-org/youtube-dl/blob/master/docs/supportedsites.md

@Jpersh27
Copy link
Author

Jpersh27 commented Feb 17, 2021

@CookieJarApps Thank you for the explanation and detailed demonstration.

1.) Do you have a set release day this week you plan on releasing the Beta build for testing?

(I know you said you planned on releasing the plugin in the next 2 or 3 days about 3 days days ago when you sent me the previous information)

@CookieJarApps
Copy link
Owner

Hopefully, the plugin will be done today - I'm just changing the plugin a bit so that it works on it's own without the browser to make it more an app that has browser integration rather than something that needs the browser to function. I'm not sure when the first v13 beta will be done, but definitely by the end of the week.

@Jpersh27
Copy link
Author

Jpersh27 commented Feb 17, 2021

@CookieJarApps Sweet definitely looking forward to trying out the plugin.

1.) How will I go about obtaining the plugin once Its available for release?

• You said your working on the plugin so that it won't be dependent on the browser itself too function. I'm assuming it will be it's own separate app?

2.) Will the plugin be available for release later today or will you be waiting to release it alongside v13 beta this weekend?

@CookieJarApps
Copy link
Owner

  1. You'll be able to get the plugin here: https://github.com/CookieJarApps/VideoDL/releases
    It will be a separate app - you'll be able to enter a video URL and it'll download it - but it'll also have integration in the form of a download button in the navbar:
    videodownload

  2. The plugin will be available later today, the only thing that won't be there is the download button in the toolbar on versions <v13, but for now using the Share option in the menu and 'sharing' the page with the VideoDL app will work in the same way.

@Jpersh27
Copy link
Author

@CookieJarApps- Thank you for the app. I however encountered a bug/issue with the video download app itself after further testing of the apps features.

• I opened an issue on the separate repository for the app instead of on this one. I just wanted to notify you here after I filled out the issue/bug report for the app.

@Jpersh27
Copy link
Author

Hey @CookieJarApps

1.) I was just wondering if you are still on track to release the first v13 beta by the end of the day today?

• I know you previously said that: “I'm not sure when the first v13 beta will be done, but definitely by the end of the week"

Thank you and looking forward to the release of the Beta and testing out the new download button feature in v13.

@CookieJarApps
Copy link
Owner

Yes, I'm still going to release v13 by the end of the day today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2: Medium priority Needs to be fixed eventually
Projects
None yet
Development

No branches or pull requests

2 participants