Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ios 7 bug #26

Closed
mrhaxic opened this issue Apr 17, 2015 · 7 comments
Closed

ios 7 bug #26

mrhaxic opened this issue Apr 17, 2015 · 7 comments

Comments

@mrhaxic
Copy link

mrhaxic commented Apr 17, 2015

First we need to edit this line

if(UIAccessibilityIsReduceMotionEnabled()) { ... }

to

if(UIAccessibilityIsReduceMotionEnabled != NULL) { ... }

for avoiding crash on iOS 7.x but after show the picker on iOS 7 the whole view be white background see image please .. http://oi58.tinypic.com/20ruvex.jpg

Could you please tell me what is going wrong ?

@CooperRS
Copy link
Owner

Hi, which version of RMPickerViewController are you using?

@mrhaxic
Copy link
Author

mrhaxic commented Apr 17, 2015

@CooperRS Hi, last version

@mrhaxic
Copy link
Author

mrhaxic commented Apr 18, 2015

Pull of @jordanmaguire solved my problem, but for version 1.4.0 it is just for your information. Thanks

@CooperRS
Copy link
Owner

I just realized that UIAccessibilityIsReduceMotionEnabled() is only available in iOS 8 and later. That means that version 1.3.3 and above of RMPickerViewController actually require iOS 8 although I said it only requires iOS 7 (at least for version 1.3.3 I said that. Version 1.4.0 only supports iOS 7 if landscape mode is not supported in the app, see main page).

I think I'll push two new versions:

  • 1.3.4 which supports iOS 7 even in apps which allow landscape mode
  • 1.4.1 which supports iOS 7, if your app does not allow landscape mode. Otherwise iOS 8 is required.

@CooperRS
Copy link
Owner

Whoops, I don't know my own controls :D

So to clarify:

  • Version 1.3.3 is fully iOS 7 compatible
  • Version 1.4.0 uses UIAccessibilityIsReduceMotionEnabled() which only is available in iOS 8.0 and above. I'll fix that in version 1.4.1 which I will push in a few moments. Version 1.4.1 is then compatible to iOS 7 as described on the main page.

@CooperRS
Copy link
Owner

Version 1.4.1 has been pushed and should fix the problem

@mrhaxic
Copy link
Author

mrhaxic commented Apr 20, 2015

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants