Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buran treats "mailto:" links as Gemini links with relative URLs #8

Closed
acidus99 opened this issue May 10, 2022 · 1 comment
Closed

Comments

@acidus99
Copy link

Buran thinks that mailto: links are gemini:// links with a relative URL.

If you are on gemini://example.com/ and click this link like

=> mailto:test@example.com Email me

Buran goes to the URL: gemini://example.com/mailto:test@example.com instead of what it should do, which is go to mailto:test@example.com which will launch the associated mail program (or nothing at all)

You don't need to specifically code for mailto: proper URL parsing would detect this. Parsing mailto:test@example.com should show a fully qualified URL with a scheme of mailto:. Its not a relative URL, because : is a reserved, general delimiter (according to the URL Generic Syntax RFC linked off the Gemini protocol spec) and it has to be escaped if used outside of the delimited between scheme or between hostname and port in the authority. Basically use a proper URL parsing library and you will be fine

@acidus99 acidus99 changed the title Buran thinks "mailto:" links are Gemini links with relative URLs Buran treats "mailto:" links as Gemini links with relative URLs May 10, 2022
@Corewala
Copy link
Owner

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants