New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move test timeouts to constants. #367
Conversation
…future, this will be configured differently on Travis
Timeouts are used all over the place, not just with the scheduled executor, but this is a good start. Other timeouts can be discovered and fixed as we go |
Michael, this patch does something weird with changing the typing of |
@slfritchie It's not changing the typing of CancellationException. What makes you think that? The patch currently has a bug because it uses |
Good to know about the units problem. My question about typing came from this test output:
|
@slfritchie Okay, and that was because the test was expecting an IOException, but the test was cancelled before the exception was thrown... |
…th wrong timevalue being passed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeh, useful constants. I suspect we'll refine this as we go along, but at this point, any step towards defining and unifying timeouts/iterations as constants is a good step.
This PR moves timeouts to constants, so that in the future different timeouts can be
set in Travis. It also forces the user to select from a set of four timeout lengths.