Assets azure #121
Merged
Assets azure #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorbenichoux
force-pushed
the
assets-azure
branch
2 times, most recently
from
f75729e
to
9970d96
Compare
|
Let's wait until https://github.com/Cornerstone-OnDemand/modelkit/pull/120/files is merged first so I can correctly update requirements |
|
Nice! |
Definitely, let me add this to the documentation! |
antoinejeannot
requested changes
Dec 9, 2021
added 6 commits
December 9, 2021 15:08
they are internally incorrect, and will lead to mypy errors see Azure/azure-sdk-for-python#20083
victorbenichoux
force-pushed
the
assets-azure
branch
from
4dfef52
to
f9e4d61
Compare
|
PTAL @antoinejeannot |
victorbenichoux
force-pushed
the
assets-azure
branch
from
4adb6de
to
d40f61a
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I add support for assets stored in Azure blob storage. It's relatively simple, since I only need to correctly implement the driver in
assets/drivers/azure.py.The rest follows: I add an assets manager fixture in
tests/assets/conftest.py, and then duplicate a bunch of tests using the same approach as for other drivers.