Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav Icons Font and Colours #452

Closed
jstet opened this issue Jun 1, 2023 · 4 comments
Closed

Nav Icons Font and Colours #452

jstet opened this issue Jun 1, 2023 · 4 comments

Comments

@jstet
Copy link
Member

jstet commented Jun 1, 2023

          Thanks! I like the elements and think that they could be useful on other pages. 

Looking at them on my big ass monitor screen, i have two concerns:

  • font: i don't think the font is well readable from an accessibility perspective when it is so small. i know we have been using it on canva for a bit but i feel for this, it is not so well suited (the letters "mush together" even for me).
  • colors: maybe we could think about different colors for the backgrounds of the icons? I think right now it implies too much of a "sequence". in [correltools](https://github.com/CorrelAid/correltools) , there the opportunity to create qualitative palettes:
scales::show_col(correltools::correlaid_pal()(5))

Screenshot 2023-05-31 at 15 37 10

or is this too many different colors? IDK.

Originally posted by @friep in #448 (comment)

@jstet
Copy link
Member Author

jstet commented Jun 1, 2023

@friep i have increased the font spacing, size etc. Does it work better now?

I intentionally used a sequence of colours so it fits to the gradient of the hero etc.

@pr130
Copy link
Contributor

pr130 commented Jun 1, 2023

where can i find this preview? sorry a bit slow today... :/

@jstet
Copy link
Member Author

jstet commented Jun 1, 2023

its on correlaid.org now because the content change required blocked other changes (see pr) thats why i opnned this issue

@pr130
Copy link
Contributor

pr130 commented Jun 2, 2023

lgtm

@pr130 pr130 closed this as completed Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants