Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Editing a taken dose time in 24H format is mapping to wrong AM/PM time&day on select #47

Closed
QueerCodingGirl opened this issue Feb 6, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@QueerCodingGirl
Copy link

Describe the bug
When i edit the time of a dose already taken the time i select on a 24H wheel gets mapped to the wrong AM or PM time&day.
This happens when pressing OK in the time selection popup. The time i selected is not the same as the new time displayed before saving. Example: My selection of 22:30 is converted to 10:30, either on the same or the next day. When i press on the time again to fix this, the selection popup and the value in the app seem even more out of sync due to time conversions, i guess.

To Reproduce
Steps to reproduce the behavior:

  1. Have a phone with a system clock set to use the 24H format
  2. edit the time of a taken dose AND actually change the time on the time wheel! (if you have trouble to reproduce this, change the time over the 12 o'clock mark)
  3. See the wrong time and sometimes day before pressing the checkmark to save. On save the wrong time&day will be saved, not the correct one. This suggests it is more than just a display bug.

Expected behavior
The time i actually selected gets displayed and saved, without changing the day when i did'nt touch the day.

Smartphone (please complete the following information):

  • Device: Motorola EDGE 20
  • OS: Android 11
  • Version: 1.6.1
  • Build Location: F-Droid release
@CorruptedArk CorruptedArk added the bug Something isn't working label Feb 6, 2022
@CorruptedArk
Copy link
Owner

Good catch, this is a weird one. I have to investigate what's going wrong

@CorruptedArk
Copy link
Owner

I figured it out, it was some stupid stuff

@QueerCodingGirl
Copy link
Author

QueerCodingGirl commented Feb 7, 2022

@CorruptedArk Thanks for the fast fix! Do you know how long it takes until the release is available over f-droid? I can't even see the release before this one yet (1.6.2)

@CorruptedArk
Copy link
Owner

It depends, but usually at least a week. Google Play will typically have the release within 1-2 days

@QueerCodingGirl
Copy link
Author

fyi: f-droid rolled out the release today and i tested this issue on my device. The issue is fixed, thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants