Skip to content
This repository has been archived by the owner on Dec 25, 2023. It is now read-only.

Remove unused bufferutil dependency #37

Closed
webmaster128 opened this issue Mar 16, 2022 · 2 comments · Fixed by #58
Closed

Remove unused bufferutil dependency #37

webmaster128 opened this issue Mar 16, 2022 · 2 comments · Fixed by #58

Comments

@webmaster128
Copy link
Member

bufferutil pulls in node-gyp-build, which is for building native code. Most likely we don't want any of those in here.

It was added in #27. Was that on purpose?

@msteiner96
Copy link
Contributor

Hmm when building the umd bundle.js I get Module not found: Error: Can't resolve 'bufferutil' without it :/

@webmaster128
Copy link
Member Author

Can you try to move it from dependenvies to devDependencies? Then apps uing this package don't pull in the dependency.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants