Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong field name in GovMsg::Vote: "vote" should be "option" #1571

Closed
webmaster128 opened this issue Jan 9, 2023 · 1 comment · Fixed by #1999
Closed

Wrong field name in GovMsg::Vote: "vote" should be "option" #1571

webmaster128 opened this issue Jan 9, 2023 · 1 comment · Fixed by #1999
Milestone

Comments

@webmaster128
Copy link
Member

webmaster128 commented Jan 9, 2023

The vote option of a MsgVote/GovMsgVote should be called option, not vote:

@@ -211,7 +211,7 @@ pub enum GovMsg {
     Vote {
         proposal_id: u64,
         /// The vote option. This should be called "option" for consistency with Cosmos SDK. Sorry for that.
-        vote: VoteOption,
+        option: VoteOption,
     },

The wrong naming currectly exists between CosmWasm and wasmvm.

Cosmos SDK naming here:

Not sure if we can ever change this but I want to mark this as our bug.

@webmaster128 webmaster128 changed the title Wrong field name in GovMsg::Vote: vote should be option Wrong field name in GovMsg::Vote: "vote" should be "option" Jan 17, 2023
@webmaster128 webmaster128 added this to the 2.0.0 milestone Jan 20, 2024
@webmaster128
Copy link
Member Author

@chipshort I think we can just rename it here and accept both field names in the wasmvm type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant