Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReceiveApproval callback #124

Open
Art3miX opened this issue Jun 15, 2023 · 0 comments
Open

ReceiveApproval callback #124

Art3miX opened this issue Jun 15, 2023 · 0 comments

Comments

@Art3miX
Copy link
Collaborator

Art3miX commented Jun 15, 2023

How about adding ReceiveApproval callback?

Logically speaking, receiving an approval to use the NFT has the same meaning as receiving the actual NFT, as far as the contract cares.
This will make the flow much easier for marketplaces that use approval system, instead of a 2 msg system, where you first send approval, and then send the actual msg.

This will reduce complexity by a lot, and reduce number of queries needed, right now on each marketplace listing, you need to query for owner and approvals, this callback will make those queries not needed as you can just pass data with the callback.

We can add the callback to existing approval msg, or create a new message (much like transfer and send).
Same idea can be applied to revoke.

Benefits:

  1. This will simplify the usage of approvals for contracts, and reduce much of the complexity
  2. Because of 1, this will increase the usage of approvals, which in my opinion are more secure then transferring ownership
  3. Doesn't break or block anything, and is backward compatible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant