Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use macros for extending CW721 execute/query messages #91

Closed
wants to merge 11 commits into from
Closed

Use macros for extending CW721 execute/query messages #91

wants to merge 11 commits into from

Conversation

larry0x
Copy link
Collaborator

@larry0x larry0x commented Oct 21, 2022 •
edited

Closes: #90

NOTES:

  • Currently CI fails because there is a clippy warning in the cw721-base contract. However, that is not within the scope of this PR.
  • The TryFrom trait suggested by Define a macro for extending CW721 execute/query messages #90 is not included in this PR
  • I'm not sure how well this approach will work with cosmwasm-schema's #[derive(QueryResponses)] macro

@larry0x
Copy link
Collaborator Author

larry0x commented Oct 21, 2022

Closing this PR, as I now think what @iboss-ptk suggested here is the more elegant solution.

@larry0x larry0x closed this Oct 21, 2022
@larry0x larry0x mentioned this pull request Oct 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define a macro for extending CW721 execute/query messages
1 participant
@larry0x