Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distinguish between weight 0 and not member in cw3 queries #154

Closed
ethanfrey opened this issue Dec 4, 2020 · 3 comments · Fixed by #158 or #159
Closed

Distinguish between weight 0 and not member in cw3 queries #154

ethanfrey opened this issue Dec 4, 2020 · 3 comments · Fixed by #158 or #159
Assignees
@maurolacy
Projects
Contract development

Comments

@ethanfrey
Copy link
Member

Cw3QueryMsg::Voter{addr: HumanAddr} should return something like cw4::MemberResponse, eg:

pub struct VoterInfo {
  pub weight: Option<u64>,
}

Do not change the VoterListResponse return info.
@ethanfrey ethanfrey mentioned this issue Dec 4, 2020
Merged
@ethanfrey ethanfrey added this to To do in Contract development Dec 4, 2020
@maurolacy maurolacy mentioned this issue Dec 7, 2020
Merged
Contract development automation moved this from To do to Done Dec 7, 2020
@maurolacy
Copy link
Contributor

maurolacy commented Dec 7, 2020 •
edited

Do not change the VoterListResponse return info.

Hmm, I see now that I missed that restriction. In any case, re-open and I'll revisit this: basically, by using two different (sub)structs for VoterResponse and VoterListResponse.

@ethanfrey ethanfrey reopened this Dec 7, 2020
Contract development automation moved this from Done to In progress Dec 7, 2020
@ethanfrey
Copy link
Member Author

I missed that too just looking at the diff.

The member list always has a value, to avoid needless unwraps

@maurolacy maurolacy mentioned this issue Dec 7, 2020
Merged
@maurolacy
Copy link
Contributor

Take a look at #159, and sorry for the confusion.

Contract development automation moved this from In progress to Done Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maurolacy maurolacy

Labels
None yet
Projects
No open projects
Contract development
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Weight 0 vs not member CosmWasm/cw-plus
Weight 0 vs not member CosmWasm/cw-plus
2 participants
@ethanfrey @maurolacy