Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sensible events/attributes to cw3/cw4 handle functions #174

Closed
ethanfrey opened this issue Dec 11, 2020 · 0 comments · Fixed by #206
Closed

Add sensible events/attributes to cw3/cw4 handle functions #174

ethanfrey opened this issue Dec 11, 2020 · 0 comments · Fixed by #206
Assignees
@ethanfrey
Projects
Contract development

Comments

@ethanfrey
Copy link
Member

Currently these all are tested functionally, but the attributes are often vec![].

Assign them all some reasonable values, like in cw20-base or cw721-base.

Also, please review if any other contracts are missing events.
@ethanfrey ethanfrey added this to To do in Contract development via automation Dec 11, 2020
@ethanfrey ethanfrey moved this from To do to In progress in Contract development Dec 21, 2020
@ethanfrey ethanfrey assigned ethanfrey and unassigned maurolacy Dec 21, 2020
@ethanfrey ethanfrey mentioned this issue Dec 21, 2020
Merged
Contract development automation moved this from In progress to Done Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethanfrey ethanfrey

Labels
None yet
Projects
No open projects
Contract development
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set events for cw4 CosmWasm/cw-plus
2 participants
@ethanfrey @maurolacy