Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SnapshotItem to storage-plus #193

Closed
ethanfrey opened this issue Dec 17, 2020 · 0 comments · Fixed by #409
Closed

Add SnapshotItem to storage-plus #193

ethanfrey opened this issue Dec 17, 2020 · 0 comments · Fixed by #409
Assignees
Milestone

Comments

@ethanfrey
Copy link
Member

Let's build the equivalent type to SnapshotMap, but for Item. We can query this at any snapshotted height. Can use the same logic for selected checkpoints (+1 for code reuse/refactor)

In particular, I want this, so I can query a snapshot of total_weight at the beginning of the block the proposal was created on . This is a vulnerability mentioned in one of the cw3-flex-multisig snapshoting prs/issues (can't find it now)

You can use this for snapshotting total weight in cw4-* and exposing history to cw3 callers in the same PR or in a separate.

@ethanfrey ethanfrey added this to To do in Contract development via automation Dec 17, 2020
@ethanfrey ethanfrey added this to the v0.9.0 milestone Aug 17, 2021
@ethanfrey ethanfrey modified the milestones: v0.9.0, v0.10.0 Sep 7, 2021
@maurolacy maurolacy moved this from To do to In progress in Contract development Sep 9, 2021
@maurolacy maurolacy mentioned this issue Sep 9, 2021
@maurolacy maurolacy moved this from In progress to Review in progress in Contract development Sep 10, 2021
@ethanfrey ethanfrey modified the milestones: v0.10.0, v0.9.0 Sep 12, 2021
Contract development automation moved this from Review in progress to Done Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants