Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contract sanity checking during build / release #228

Closed
maurolacy opened this issue Mar 2, 2021 · 0 comments · Fixed by #240
Closed

Add contract sanity checking during build / release #228

maurolacy opened this issue Mar 2, 2021 · 0 comments · Fixed by #240
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@maurolacy
Copy link
Contributor

maurolacy commented Mar 2, 2021

Let's add sanity checking (check exports, imports, deterministic middleware, ...) to wasm-compiled (.wasm) smart contracts.

An easy way to do this would be to add a simple / dummy integration test for the contract. Given that compiling and running integration tests is expensive, we could run these tests in the CI only during the contract building / release step.

An alternative or complement to this would be to use a small utility to just compile the contract. Something similar to module_size. Perhaps with some additional checks / validations.

Let's do this for cosmwasm-plus contracts, and also cosmwasm and cosmwasm-examples contracts.

@maurolacy maurolacy changed the title Add a contracr compilation check during build / release Add contract sanity checking during build / release Mar 2, 2021
@ethanfrey ethanfrey added this to To do in Contract development Mar 4, 2021
@ethanfrey ethanfrey added this to the 0.6.0 milestone Mar 4, 2021
@maurolacy maurolacy self-assigned this Mar 8, 2021
@maurolacy maurolacy added the enhancement New feature or request label Mar 8, 2021
@maurolacy maurolacy moved this from To do to In progress in Contract development Mar 8, 2021
@maurolacy maurolacy moved this from In progress to Review in progress in Contract development Mar 8, 2021
Contract development automation moved this from Review in progress to Done Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants