Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support submessages in multitest #259

Closed
2 tasks
ethanfrey opened this issue Apr 1, 2021 · 1 comment · Fixed by #323
Closed
2 tasks

Support submessages in multitest #259

ethanfrey opened this issue Apr 1, 2021 · 1 comment · Fixed by #323
Assignees
Milestone

Comments

@ethanfrey
Copy link
Member

ethanfrey commented Apr 1, 2021

This is a collection of items to do (multiple PRs, can be broken into issues).
Follow up from #257 and #258

  • Support reply method on contracts
  • Process submessages if returned from contract execution
@ethanfrey ethanfrey added this to the 0.6.0 milestone Apr 1, 2021
@ethanfrey ethanfrey added this to To do in Contract development via automation Apr 1, 2021
@ethanfrey ethanfrey changed the title Improve multitest Support submessages in multitest Apr 12, 2021
@ethanfrey ethanfrey self-assigned this Apr 12, 2021
@ethanfrey ethanfrey modified the milestones: 0.6.0, 0.6.1 May 3, 2021
@ethanfrey
Copy link
Member Author

Looks like this needs to be urgently fixed for the 0.15.0 upgrade:

            CosmosMsg::Wasm(msg) => {
                let (resender, res) = self.handle_wasm(sender, msg)?;
                let mut attributes = res.attributes;
                // recurse in all messages
                for resend in res.messages {
                    let subres = self.execute(resender.clone(), SubMsg::new(resend))?;
                    // ignore the data now, just like in wasmd
                    // append the events
                    attributes.extend_from_slice(&subres.attributes);
                }
                Ok(AppResponse {
                    attributes,
                    data: res.data,
                })
            }

@ethanfrey ethanfrey modified the milestones: 0.6.1, v0.7.0 Jul 12, 2021
This was referenced Jul 12, 2021
@ethanfrey ethanfrey moved this from To do to In progress in Contract development Jul 13, 2021
Contract development automation moved this from In progress to Done Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant