Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all cw20 sends use Binary not Option<Binary> #296

Closed
ethanfrey opened this issue Jun 4, 2021 · 1 comment · Fixed by #321
Closed

Ensure all cw20 sends use Binary not Option<Binary> #296

ethanfrey opened this issue Jun 4, 2021 · 1 comment · Fixed by #321
Milestone

Comments

@ethanfrey
Copy link
Member

ex: https://github.com/CosmWasm/cosmwasm-plus/blob/main/packages/cw20/src/msg.rs#L16

This was updated in cw20-base, but I forgot the cw20 spec. Let's check all usage in all packages and ensure they match

@pronvis
Copy link
Contributor

pronvis commented Jun 7, 2021

Even inside cw20 messages differ :)
cw20-0.6.1/src/receiver.rs:

pub struct Cw20ReceiveMsg {
    pub sender: String,
    pub amount: Uint128,
    pub msg: Binary,
}

cw20-0.6.1/src/msg.rs:

    Send {
        contract: String,
        amount: Uint128,
        msg: Option<Binary>,
    },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants