Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper event/data handling on reply in multitest #326

Closed
ethanfrey opened this issue Jul 13, 2021 · 1 comment · Fixed by #328
Closed

Proper event/data handling on reply in multitest #326

ethanfrey opened this issue Jul 13, 2021 · 1 comment · Fixed by #328

Comments

@ethanfrey
Copy link
Member

In #323, we added support for handling SubMsg in multi-test. Namely, execution was only committed to state on success (multi-level caches) and if reply_on matched, they reply was called from the contract that sent the SubMsg.

All state is properly updated. However, I think we don't properly handle events or data when reply is called (combining them with the actual execution).

In fact, with some reflection, I think we may be doing the wrapping in the wrong place.

@ethanfrey
Copy link
Member Author

closed with #328 and #323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant