Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix min threshold and vote power bugs in cw3-flex-multisig #527

Closed
2 tasks done
ueco-jb opened this issue Nov 4, 2021 · 2 comments · Fixed by #528
Closed
2 tasks done

Fix min threshold and vote power bugs in cw3-flex-multisig #527

ueco-jb opened this issue Nov 4, 2021 · 2 comments · Fixed by #528
Assignees
@ueco-jb
Labels
bug Something isn't working

Comments

@ueco-jb
Copy link
Collaborator

ueco-jb commented Nov 4, 2021 •
edited

While reusing contracts in other repository, we noticed that implementation of cw3-flex-multisig contained couple of issues.

  • member weight before proposing and voting should be checked for >= 1 (0 weight voter can't perform those operation)
  • threshold value should be required >= 0.5
@ueco-jb ueco-jb added the bug Something isn't working label Nov 4, 2021
@ueco-jb ueco-jb self-assigned this Nov 4, 2021
@ueco-jb ueco-jb mentioned this issue Nov 4, 2021
Merged
@maurolacy maurolacy changed the title Fix threashold and vote power bug in cw3-flex-multisig Fix min threshold and vote power bug in cw3-flex-multisig Nov 4, 2021
@maurolacy maurolacy changed the title Fix min threshold and vote power bug in cw3-flex-multisig Fix min threshold and vote power bugs in cw3-flex-multisig Nov 4, 2021
@maurolacy
Copy link
Contributor

After this, it would be good to add similar checks / fixes to cw3-fixed-multisig (here or in another PR).

@ueco-jb ueco-jb mentioned this issue Nov 16, 2021
Closed
@ueco-jb
Copy link
Collaborator Author

ueco-jb commented Nov 16, 2021

After this, it would be good to add similar checks / fixes to cw3-fixed-multisig (here or in another PR).

#551

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ueco-jb ueco-jb

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix min threshold in cw3-flex-multisig CosmWasm/cw-plus
2 participants
@maurolacy @ueco-jb